Skip to content

Update debug fields #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update debug fields #674

merged 2 commits into from
Dec 4, 2023

Conversation

@haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Dec 3, 2023

No description provided.

@haslinghuis haslinghuis self-assigned this Dec 3, 2023
@haslinghuis haslinghuis mentioned this pull request Dec 3, 2023
Closed
@blckmn
Copy link
Member

blckmn commented Dec 3, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> FAIL
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis changed the title Uodate debug fields Update debug fields Dec 3, 2023
nerdCopter
nerdCopter previously approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving untested

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 4, 2023 •
edited
Loading

Sorry have to do a little update:

image

ATTITUDE has been removed as it uses the default return set (see line 1144).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.3% 8.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

nerdCopter
nerdCopter approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • re-approving. it runs, but i have no BBL with the needed fields to test.

@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 4, 2023

Copy pasted from @ctzsnooze as he asked me to take these in otherwise he needed rebase and more work to do.

@haslinghuis haslinghuis merged commit 9961080 into betaflight:master Dec 4, 2023
@haslinghuis haslinghuis deleted the add-more-missing-debugs branch December 4, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@haslinghuis @blckmn @nerdCopter