feat: fix delete workspace on reload #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for origin-blackbox-logviewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
now workspace persist after page updates, thanks |
haslinghuis
reviewed
Mar 27, 2024
haslinghuis
approved these changes
Mar 27, 2024
|
demvlad
pushed a commit
to demvlad/blackbox-log-viewer
that referenced
this pull request
Mar 27, 2024
* feat: fix delete workspace on reload * Update src/main.js --------- Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
demvlad
pushed a commit
to demvlad/blackbox-log-viewer
that referenced
this pull request
Mar 27, 2024
* feat: fix delete workspace on reload * Update src/main.js --------- Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
demvlad
pushed a commit
to demvlad/blackbox-log-viewer
that referenced
this pull request
Mar 27, 2024
* feat: fix delete workspace on reload * Update src/main.js --------- Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where if workspace file was loaded in, reloading the page would reset them.
There is still issues it seems with creating new workspace layouts, will address in separate PR