Skip to content

Added TELEMETRY_MAVLINK debug fields settings #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 3, 2025
Merged

Added TELEMETRY_MAVLINK debug fields settings #864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6effa8d
Added TELEMETRY_MAVLINK debug fields settings
demvlad Oct 3, 2025
cdbbea5
Resolved SonarCloud notices
demvlad Oct 3, 2025
9e44426
Code style improvement
demvlad Oct 3, 2025
14e8ef0
Code style improvement
demvlad Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/flightlog_fielddefs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,13 +552,18 @@ export function adjustFieldDefsList(firmwareType, firmwareVersion) {
DEBUG_MODE.splice(DEBUG_MODE.indexOf('GPS_RESCUE_THROTTLE_PID'), 1, 'AUTOPILOT_ALTITUDE');
DEBUG_MODE.splice(DEBUG_MODE.indexOf("GYRO_SCALED"), 1);
DEBUG_MODE.splice(DEBUG_MODE.indexOf("RANGEFINDER_QUALITY") + 1, 0, "OPTICALFLOW");
DEBUG_MODE.push('TPA');
DEBUG_MODE.push('S_TERM');
DEBUG_MODE.push('SPA');
DEBUG_MODE.push('TASK');
DEBUG_MODE.push('GIMBAL');
DEBUG_MODE.push('WING_SETPOINT');
DEBUG_MODE.push('AUTOPILOT_POSITION');
DEBUG_MODE.push(
'TPA',
'S_TERM',
'SPA',
'TASK',
'GIMBAL',
'WING_SETPOINT',
'AUTOPILOT_POSITION',
'CHIRP',
'FLASH_TEST_PRBS',
'MAVLINK_TELEMETRY',
);
}
if (semver.gte(firmwareVersion, "2025.12.0")) {
//rename DUAL_GYRO_ to MULTI_GYRO
Expand Down Expand Up @@ -623,7 +628,7 @@ export function adjustFieldDefsList(firmwareType, firmwareVersion) {
);
}
}

FLIGHT_LOG_FLIGHT_MODE_NAME = makeReadOnly(FLIGHT_LOG_FLIGHT_MODE_NAME);
} else {
DEBUG_MODE = DEBUG_MODE_COMPLETE;
Expand Down
7 changes: 7 additions & 0 deletions src/flightlog_fields_presenter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,6 +1134,13 @@ const DEBUG_FRIENDLY_FIELD_NAMES_INITIAL = {
"debug[4]": "Stick Limit",
"debug[5]": "Speed Limit",
},
MAVLINK_TELEMETRY: {
"debug[all]": "MAVLink telemetry",
"debug[0]": "Should send telemetry",
"debug[1]": "Actual free TX buffers space",
"debug[2]": "Estimated free TX buffers space",
"debug[3]": "Telemetries call counter",
},
};

let DEBUG_FRIENDLY_FIELD_NAMES = null;
Expand Down
38 changes: 34 additions & 4 deletions src/graph_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ GraphConfig.getDefaultCurveForField = function (flightLog, fieldName) {
min: 0,
max: 1,
},
};
};
case "debug[6]": // outlier count 0-3
case "debug[7]": // valid count 0-3
return {
Expand All @@ -605,7 +605,7 @@ GraphConfig.getDefaultCurveForField = function (flightLog, fieldName) {
min: 0,
max: 50, // put them at the very bottom
},
};
};
default:
return getCurveForMinMaxFields(fieldName);
}
Expand Down Expand Up @@ -859,15 +859,15 @@ GraphConfig.getDefaultCurveForField = function (flightLog, fieldName) {
min: 0,
max: 1,
},
};
};
case "debug[7]": // smoothed Rx Rate Hz
return {
power: 1.0,
MinMax: {
min: 0,
max: 1200,
},
};
};
default:
return getCurveForMinMaxFields(fieldName);
}
Expand Down Expand Up @@ -1454,6 +1454,36 @@ GraphConfig.getDefaultCurveForField = function (flightLog, fieldName) {
default:
return getCurveForMinMaxFields(fieldName);
}
case "MAVLINK_TELEMETRY":
switch (fieldName) {
case "debug[0]":
return {
power: 1,
MinMax: {
min: 0,
max: 1,
},
};
case "debug[1]":
case "debug[2]":
return {
power: 1,
MinMax: {
min: 0,
max: 100,
},
};
case "debug[3]":
return {
power: 1,
MinMax: {
min: 0,
max: 50,
},
};
default:
return getCurveForMinMaxFields(fieldName);
}
}
}
// if not found above then
Expand Down