test: no hanging promise#5898
Merged
himself65 merged 1 commit intoNov 11, 2025
Merged
Conversation
|
@himself65 is attempting to deploy a commit to the better-auth Team on Vercel. A member of the Team first needs to authorize it. |
better-auth
@better-auth/cli
@better-auth/core
@better-auth/expo
@better-auth/passkey
@better-auth/sso
@better-auth/stripe
@better-auth/telemetry
commit: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a hanging promise issue in the organization test suite by properly awaiting an asynchronous operation.
- Added
awaitkeyword toauth.api.setActiveOrganization()call to ensure the promise is properly handled
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
via the queue into
better-auth:canary
with commit Nov 11, 2025
a36982a
16 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/better-auth/better-auth/actions/runs/19255020378/job/55047819906?pr=5891
Summary by cubic
Added await to auth.api.setActiveOrganization in organization.test to prevent a hanging promise. Stabilizes the “get active member” test and fixes the failing CI run.
Written for commit 9a2bae5. Summary will update automatically on new commits.