Skip to content

test: no hanging promise#5898

Merged
himself65 merged 1 commit into
better-auth:canaryfrom
himself65:himself65/2025/11/10/test
Nov 11, 2025
Merged

test: no hanging promise#5898
himself65 merged 1 commit into
better-auth:canaryfrom
himself65:himself65/2025/11/10/test

Conversation

@himself65
Copy link
Copy Markdown
Contributor

@himself65 himself65 commented Nov 11, 2025

Fixes: https://github.com/better-auth/better-auth/actions/runs/19255020378/job/55047819906?pr=5891


Summary by cubic

Added await to auth.api.setActiveOrganization in organization.test to prevent a hanging promise. Stabilizes the “get active member” test and fixes the failing CI run.

Written for commit 9a2bae5. Summary will update automatically on new commits.

Copilot AI review requested due to automatic review settings November 11, 2025 04:40
@himself65 himself65 requested a review from Bekacru as a code owner November 11, 2025 04:40
@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 11, 2025

@himself65 is attempting to deploy a commit to the better-auth Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Nov 11, 2025

Open in StackBlitz

better-auth

npm i https://pkg.pr.new/better-auth/better-auth@5898

@better-auth/cli

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/cli@5898

@better-auth/core

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/core@5898

@better-auth/expo

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/expo@5898

@better-auth/passkey

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/passkey@5898

@better-auth/sso

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/sso@5898

@better-auth/stripe

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/stripe@5898

@better-auth/telemetry

npm i https://pkg.pr.new/better-auth/better-auth/@better-auth/telemetry@5898

commit: 9a2bae5

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a hanging promise issue in the organization test suite by properly awaiting an asynchronous operation.

  • Added await keyword to auth.api.setActiveOrganization() call to ensure the promise is properly handled

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@himself65 himself65 added this pull request to the merge queue Nov 11, 2025
Merged via the queue into better-auth:canary with commit a36982a Nov 11, 2025
16 of 19 checks passed
@better-auth better-auth locked as resolved and limited conversation to collaborators Apr 1, 2026
@bytaesu bytaesu added the locked Locked conversations after being closed for 7 days label Apr 1, 2026
@gustavovalverde gustavovalverde added the organization Org, teams, roles, permissions, admin, access control label Apr 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked Locked conversations after being closed for 7 days organization Org, teams, roles, permissions, admin, access control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants