Add header to route card#485
Merged
guytepper merged 27 commits intobetter-rail:mainfrom Nov 14, 2025
Merged
Conversation
drehelis
commented
Sep 23, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable header to route cards displaying train information, controlled through a new UI settings page. The feature is disabled by default and requires users to enable it through settings.
- Added a UI settings screen with a toggle for showing route card headers
- Extended API models to include train wagon data for determining train types
- Implemented train type detection and icon display in route card headers
Reviewed Changes
Copilot reviewed 12 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/services/api/route-api.ts | Passes through visaWagonData from API response |
| app/services/api/rail-api.types.ts | Adds VisaWagonData and Wagon interfaces for train information |
| app/screens/settings/settings-ui-screen.tsx | Creates new UI settings screen with route card header toggle |
| app/screens/settings/settings-screen.tsx | Adds navigation to UI settings screen |
| app/screens/index.ts | Exports new UI settings screen |
| app/navigators/settings/settings-navigator.tsx | Adds UI settings route to navigation stack |
| app/models/settings/settings.ts | Adds showRouteCardHeader setting to state model |
| app/i18n/*.json | Adds translations for train types and UI settings |
| app/components/route-card/route-card.tsx | Implements conditional header display with train information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
guytepper
reviewed
Nov 8, 2025
| stopsText={stopsText} | ||
| isRideActive={props.isActiveRide} | ||
| /> | ||
| {mainTrain.originPlatform > 0 && ( |
Member
|
/publish |
Member
|
/publish |
Member
|
/publish |
2 similar comments
Member
Author
|
/publish |
Member
Author
|
/publish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follwoing #474
After some internal discussions, we agreed to create "UI settings" page and to put this feature off by default.