🐛 - Add tap to retry hint to Android widget connection error

[guytepper]

Summary

• Appends "⋅ Tap to retry" text after the "Connection error" message in the Android widget error state, so users know the widget is tappable to refresh.

Test plan

• Simulate a connection error on the Android widget and verify the error text shows "Connection error ⋅ Tap to retry"
• Verify Hebrew and Russian locales display the translated tap to retry hint

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience of the Android widget by providing a clear visual cue that the widget can be tapped to retry a connection when an error occurs. This change aims to improve usability by guiding users on how to resolve connection issues directly from the widget interface, making the functionality more discoverable.

Highlights

• Android Widget UX Improvement: Appended "⋅ Tap to retry" text to the "Connection error" message displayed in the Android widget's error state, providing a clear visual cue that the widget is interactive for refreshing data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• android/app/src/main/java/com/betterrail/widget/state/WidgetState.kt
  • Modified the WidgetStateRenderer to concatenate the "connection_error" string with a "tap_to_retry" string, separated by a middle dot, for display on the widget platform text.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses the user experience by adding a 'Tap to retry' hint to the Android widget's connection error state. The change correctly utilizes string resources for the primary messages. However, there's an opportunity to improve internationalization by using a formatted string resource for the combined error message, which would provide greater flexibility for translators.

[gemini-code-assist]

While the individual strings connection_error and tap_to_retry are localized, the concatenation with a hardcoded separator ' ⋅ ' can lead to internationalization issues. It is best practice to define the entire phrase, including the separator, as a single formatted string resource. This allows translators to correctly order and translate the complete message for different locales, ensuring grammatical correctness and natural flow. You would need to add a new string resource in strings.xml like <string name="connection_error_with_retry_hint">%1$s ⋅ %2$s</string>.

Suggested change

	views.setTextViewText(R.id.widget_platform, context.getString(R.string.connection_error) + " ⋅ " + context.getString(R.string.tap_to_retry))
	views.setTextViewText(R.id.widget_platform, context.getString(R.string.connection_error_with_retry_hint, context.getString(R.string.connection_error), context.getString(R.string.tap_to_retry)))