Skip to content

fix(tools): implemented proper bcrypt generator (#13)#23

Merged
SyedFahad7 merged 1 commit intobetterbugs:developfrom
datta-sayak:feat/bcrypt-generator
Feb 28, 2026
Merged

fix(tools): implemented proper bcrypt generator (#13)#23
SyedFahad7 merged 1 commit intobetterbugs:developfrom
datta-sayak:feat/bcrypt-generator

Conversation

@datta-sayak
Copy link
Contributor

@datta-sayak datta-sayak commented Feb 25, 2026

Description

  • Replaced a placeholder hashing implementation in BcryptGenerator with the bcryptjs library.
  • Switched from a mock SHA-256 logic to standard bcrypt salt and hash generation.
  • Updated verifyHash to use bcrypt.compare for accurate validation.

Dependencies

Added bcryptjs and its corresponding TypeScript types.

Mentions

@rishima17

Developer's checklist

  • My PR follows the style guidelines of this project
  • I have performed a self-check on my work

If changes are made in the code:

  • I have followed the Coding Guidelines
  • My changes in code generate no new warnings
  • My changes are not breaking another fix/feature of the project
  • I have added test cases to show that my feature works
  • I have added relevant screenshots in my PR
  • There are no UI/UX issues

Copy link
Collaborator

@SyedFahad7 SyedFahad7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation, this looks solid.

@SyedFahad7 SyedFahad7 merged commit 94d19be into betterbugs:develop Feb 28, 2026
github-actions bot pushed a commit that referenced this pull request Feb 28, 2026
# [1.4.0-develop.2](v1.4.0-develop.1...v1.4.0-develop.2) (2026-02-28)

### Bug Fixes

* **tools:** implement proper bcrypt generator ([94d19be](94d19be)), closes [#23](#23) [#13](#13)
@github-actions
Copy link

🎉 This PR is included in version 1.4.0-develop.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants