feat: add ability to push components with just the minimal data without the function json#502
Merged
Gopi200 merged 2 commits intoApr 14, 2026
Conversation
Gopi200
force-pushed
the
feat/add-support-for-multiple-functions-in-wasm-components-PHOEN-847
branch
2 times, most recently
from
e84ec24 to
69b5357
Compare
…ut the function json
Gopi200
force-pushed
the
feat/add-support-for-multiple-functions-in-wasm-components-PHOEN-847
branch
from
a55aa83 to
69b5357
Compare
|
jrquak
requested changes
Apr 14, 2026
| } | ||
| const functionJson = getFunctionJsonFromDir(functionDir); | ||
|
|
||
| if (!functionJson) { |
Collaborator
There was a problem hiding this comment.
Why is this check removed?
Collaborator
Author
There was a problem hiding this comment.
Because we now want to send the component to the block store even when we don't have a function json so the block store can automatically generate one.
jrquak
approved these changes
Apr 14, 2026
Gopi200
deleted the
feat/add-support-for-multiple-functions-in-wasm-components-PHOEN-847
branch
Collaborator
|
🎉 This PR is included in version 26.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.