don't flip sprites twice

[mockersf]

Objective

• After ExtractedSprites slice buffer #17041, sprite flipping doesn't work

Solution

• Sprite flipping is applied twice:
  

  bevy/crates/bevy_sprite/src/render/mod.rs

  Lines 766 to 773 in b6ccc2a

  	if extracted_sprite.flip_x {
  	uv_offset_scale.x += uv_offset_scale.z;
  	uv_offset_scale.z *= -1.0;
  	}
  	if extracted_sprite.flip_y {
  	uv_offset_scale.y += uv_offset_scale.w;
  	uv_offset_scale.w *= -1.0;
  	}

  
  

  bevy/crates/bevy_sprite/src/render/mod.rs

  Lines 792 to 799 in b6ccc2a

  	if extracted_sprite.flip_x {
  	uv_offset_scale.x += uv_offset_scale.z;
  	uv_offset_scale.z *= -1.0;
  	}
  	if extracted_sprite.flip_y {
  	uv_offset_scale.y += uv_offset_scale.w;
  	uv_offset_scale.w *= -1.0;
  	}

• Keep one

[bushrat011899]

Out of curiosity, the linked PR didn't flag as causing a rendering change. Do we know why? Might be good to diagnose so we can rely on that (really helpful!) test more.

[ickshonpe]

😓

[ickshonpe]

Out of curiosity, the linked PR didn't flag as causing a rendering change. Do we know why? Might be good to diagnose so we can rely on that (really helpful!) test more.

Testbed_2d just doesn't have any sprite flipping. Just needs the sprite from its sprite example module copied another three times flipped in each axis and both.

[mockersf]

Out of curiosity, the linked PR didn't flag as causing a rendering change. Do we know why? Might be good to diagnose so we can rely on that (really helpful!) test more.

I put in the testbed a few cases that I had in mind, but they're definitely not covering everything. We have to balance duration and coverage. We get a better coverage by running all the examples (https://thebevyflock.github.io/bevy-example-runner/index.html) but that's not on every PR ci as it takes 1.5 hour.

That said, adding sprite flipping shouldn't add any duration, so it's a good idea to do 👍