Type-erased Specializers#20391
Closed
ecoskey wants to merge 4 commits into
Closed
Conversation
ecoskey
added
C-Feature
ecoskey
added
S-Needs-Review
ecoskey
force-pushed
the
feat/spec_v2/dyn
branch
from
d53dcb5 to
ddf6e47
Compare
ecoskey
added
S-Needs-Review
alice-i-cecile
requested changes
Oct 1, 2025
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Needs a migration guide :)
alice-i-cecile
added
the
M-Migration-Guide
Contributor
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
This comment was marked as resolved.
This comment was marked as resolved.
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Migration guide looks fine, but I don't have the rendering chops to review this further :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add type-erased wrappers around
SpecializerandSpecializerKeyCurrently, type-erased materials have their key type and key getter located in
AsBindGroup, and theirspecializefn located inMaterial. This is mostly an experiment, but I think erased specializers might be a good way to wrap all that logic up nicely.Currently there's more boxing than there should be, I'll probably switch to some form of
bytemuckorSmallBoxlater