-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Make it easier to write tests involving fixed timesteps #21705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ownezx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps making sure that the u32 is non zero would avoid silliness?
That being said it's clear enough that zero would likely not be used.
Jondolf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved on behalf of @NiseVoid
|
@Ownezx well, 0 is a valid state here: using 0 will in fact ensure that the fixed timestep is never run. Might be useful for disabling fixed updates in a test? Though it would also not advance time at all, so idk how useful that would be in practice. |

Objective
app.update()triggers a fixed updateSolution
TimeUpdateStrategy::FixedTimestepsthat advances time by the fixed timestep automatically:Testing