Skip to content

Conversation

@andriyDev
Copy link
Contributor

Objective

Solution

  • Use a lock to block reading the source directory until after processing has started. This way the asset processor can't even check if there's work to do until the guard is released, so we can't miss the processing state.

Testing

  • Ran it locally with singlethreaded and multithreaded mode.

@andriyDev andriyDev added A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 31, 2025
@andriyDev andriyDev requested a review from kristoff3r October 31, 2025 23:51
Copy link
Contributor

@kristoff3r kristoff3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really clever!

@andriyDev andriyDev force-pushed the flaky-processing-tests branch from 77d0cff to d001e03 Compare November 1, 2025 00:08
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Nov 1, 2025
@cart cart added this pull request to the merge queue Nov 1, 2025
Merged via the queue into bevyengine:main with commit 766be7d Nov 1, 2025
38 checks passed
@andriyDev andriyDev deleted the flaky-processing-tests branch November 1, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Testing A change that impacts how we test Bevy or how users test their apps D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants