GridTrack::percent(): Clarify value range
#21922
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the value range for GridTrack::percent() since it doesn't follow the usual 0.0 to 1.0 range and instead uses 0.0 to 100.0.
JMS55
approved these changes
Nov 23, 2025
ickshonpe
suggested changes
Nov 24, 2025
| } | ||
|
|
||
| /// Create a grid track with a percentage size | ||
| /// Note that the percentage is represented as a value from 0.0 to 100.0 |
Contributor
There was a problem hiding this comment.
The idea is good, but the comment text needs to be reworked a bit. It would be easy to misinterpret this as implying that the function only accepts values in the range 0.0 to 100.0, which isn't correct.
ickshonpe
added
D-Trivial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the value range for
GridTrack::percent()since it doesn't follow the usual 0.0 to 1.0 range and instead uses 0.0 to 100.0.Minor documentation change with no change to code, tests, or examples.