Don't update the text buffer in text_system
#21966
Open
+230
−87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Text is shaped in
measure_text_system. When the schedule reachestext_systemthere's no need to reupdate the cosmic-text buffer a second time.text_systemshould only be updating any staleTextLayoutInfocomponents.Solution
update_text_layout_infotoTextPipeline. This method updates the givenTextLayoutInfowithout performing any shaping.update_text_layout_infoinstead ofqueue_textfromtext_system.TextFont, instead of the fullTextUiReader.There are some more changes that seem desirable, the glyph info updates should probably be done in
measure_systemfor instance, but I'll leave those for followup PRs.Testing
yellow = this PR, red = main