Skip to content

Fix shadow caster/receiver toggle not working #22004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Dec 14, 2025
Merged

Fix shadow caster/receiver toggle not working #22004

alice-i-cecile merged 1 commit into from
Dec 14, 2025

Conversation

@momoluna444
Copy link
Contributor

@momoluna444 momoluna444 commented Dec 2, 2025

Objective

Fixes #21582

Solution

In the original implementation of extract_meshes_for_gpu_building, we didn’t account for the case where components are removed. This patch adds fixes for all affected components.

Testing

The example shadow_caster_receiver works now.

@alice-i-cecile alice-i-cecile added this to the 0.18 milestone Dec 2, 2025
@Zeophlite Zeophlite added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 4, 2025
andriyDev
andriyDev approved these changes Dec 14, 2025
View reviewed changes
Copy link
Contributor

@andriyDev andriyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible!

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 14, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 14, 2025
Merged via the queue into bevyengine:main with commit be4f4e7 Dec 14, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@atlv24 atlv24 Awaiting requested review from atlv24

+1 more reviewer

@andriyDev andriyDev andriyDev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.18

Development

Successfully merging this pull request may close these issues.

Toggling shadow caster/receiver doesn't work in the example

4 participants

@momoluna444 @alice-i-cecile @andriyDev @Zeophlite