fix use-after-free in AddObserver
#22158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22152
Solution
From the safety notes on
DynamicBundle::apply_effect:The
MovingPtrhere is dropped when it goes out of scope, so theassume_inithere is invalid. This is fixed bymem::forget-ing the pointer inget_components, which will leave the allocation intact forapply_effect.Testing
Using the example from the issue, the logs are correct after this patch