Skip to content

Emit a warn_once if a font size is larger than 1000 #22642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alice-i-cecile merged 1 commit into from
Jan 24, 2026
Merged

Emit a warn_once if a font size is larger than 1000 #22642

alice-i-cecile merged 1 commit into from
Jan 24, 2026

Conversation

@WaterWhisperer
Copy link
Contributor

@WaterWhisperer WaterWhisperer commented Jan 22, 2026

Objective

Solution

  • Add a WARN_FONT_SIZE const and emit a warn_once when font size larger than it
  • Change some once!(warn!()) to warn_once!()

Testing

  • Did you test these changes? If so, how?
    cargo check

ickshonpe
ickshonpe suggested changes Jan 22, 2026
View reviewed changes
ickshonpe
ickshonpe reviewed Jan 22, 2026
View reviewed changes
@alice-i-cecile
Copy link
Member

alice-i-cecile commented Jan 22, 2026

@WaterWhisperer feel free to resolve comments you've addressed to make it easier for reviewers :) Good work though!

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Text Rendering and layout for characters X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 22, 2026
@hukasu hukasu added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 23, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 24, 2026
Merged via the queue into bevyengine:main with commit 34321d2 Jan 24, 2026
50 checks passed
@WaterWhisperer WaterWhisperer deleted the warn-font-size branch January 25, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+3 more reviewers

@ickshonpe ickshonpe ickshonpe requested changes

@hukasu hukasu hukasu approved these changes

@DaAlbrecht DaAlbrecht DaAlbrecht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Text Rendering and layout for characters C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enormous fonts can cause performance issues

5 participants

@WaterWhisperer @alice-i-cecile @hukasu @ickshonpe @DaAlbrecht