Skip to content

Prepare custom post processing bind groups ahead of time#22887

Open
IceSentry wants to merge 3 commits intobevyengine:mainfrom
IceSentry:custom_post_process_bind_groups
Open

Prepare custom post processing bind groups ahead of time#22887
IceSentry wants to merge 3 commits intobevyengine:mainfrom
IceSentry:custom_post_process_bind_groups

Conversation

@IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Feb 10, 2026

Objective

  • Encoding systems shouldn't have local state

Solution

  • Prepare bind groups in a prepare system to avoid local state

Testing

  • I tested the example and it worked

@IceSentry IceSentry added the A-Rendering Drawing game state to the screen label Feb 10, 2026
@IceSentry IceSentry added C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Examples An addition or correction to our examples labels Feb 10, 2026
pcwalton
pcwalton approved these changes Feb 10, 2026
View reviewed changes
examples/shader_advanced/custom_post_processing.rs
struct PostProcessBindGroups {
a: (TextureViewId, BindGroup),
b: (TextureViewId, BindGroup),
}
Copy link
Contributor

@pcwalton pcwalton Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, though I wonder if we can factor this out into a generic helper for custom postprocessing passes in the future...

Copy link
Contributor

@pcwalton pcwalton Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, never mind, I saw your other comment about this.

@alice-i-cecile alice-i-cecile added the X-Uncontroversial This work is generally agreed upon label Feb 10, 2026
@cart cart added this to Rendering Feb 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tychedelia tychedelia Awaiting requested review from tychedelia

1 more reviewer

@pcwalton pcwalton pcwalton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon

Projects

Rendering
Status: Needs SME Triage
Rendering (Old)
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IceSentry @pcwalton @alice-i-cecile