Skip to content

Prepare tonemapping bind groups ahead of time#22890

Open
IceSentry wants to merge 1 commit intobevyengine:mainfrom
IceSentry:tonemapping_aot_bind_groups
Open

Prepare tonemapping bind groups ahead of time#22890
IceSentry wants to merge 1 commit intobevyengine:mainfrom
IceSentry:tonemapping_aot_bind_groups

Conversation

@IceSentry
Copy link
Contributor

@IceSentry IceSentry commented Feb 10, 2026

Objective

  • Bind groups can be created in prepare

Solution

  • Create the bind groups in prepare

Testing

  • All the tonemappers in the example still work as expected

@IceSentry IceSentry added the A-Rendering Drawing game state to the screen label Feb 10, 2026
@IceSentry IceSentry added C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 10, 2026
@alice-i-cecile alice-i-cecile added the X-Uncontroversial This work is generally agreed upon label Feb 10, 2026
pcwalton
pcwalton approved these changes Feb 10, 2026
View reviewed changes
Copy link
Contributor

@pcwalton pcwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cart cart added this to Rendering Feb 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tychedelia tychedelia Awaiting requested review from tychedelia

2 more reviewers

@pcwalton pcwalton pcwalton approved these changes

@dloukadakis dloukadakis dloukadakis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Uncontroversial This work is generally agreed upon

Projects

Rendering
Status: Needs SME Triage
Rendering (Old)
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IceSentry @pcwalton @dloukadakis @alice-i-cecile