docs and tests for on_primitive#23130
Open
ChristopherBiscardi wants to merge 3 commits intobevyengine:mainfrom
Open
docs and tests for on_primitive#23130ChristopherBiscardi wants to merge 3 commits intobevyengine:mainfrom
ChristopherBiscardi wants to merge 3 commits intobevyengine:mainfrom
Conversation
andriyDev
approved these changes
Feb 25, 2026
Contributor
|
Based on your description, did you intend to add tests for the 2+ case? I'm only seeing one for the 0 case. Otherwise looks good! |
Contributor
Author
|
@Smerom I don't currently plan to. The |
Smerom
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add additional tests and docs for the
on_primitivehook introduced in #22907Solution
Tests currently only test failure conditions such as
Which is the most important place to notify users early, considering the additional complexity incurred by following the
gltfcrate's types here.Testing