Add SliderOrientation to control slider axis detection#23310
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Mar 11, 2026
Merged
Add SliderOrientation to control slider axis detection#23310alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
The Slider widget auto-detects orientation based on dimensions (vertical if height > width). This causes the Feathers slider to behave as vertical when its layout happens to be taller than wide, while its visuals (gradient, cursor) are hardcoded as horizontal. Add a SliderOrientation enum (Auto/Horizontal/Vertical) to give explicit control over the slider axis. Set the Feathers sliders to Horizontal so their interaction matches their visual presentation. Fixes bevyengine#23294
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
mnmaita
added
C-Feature
alice-i-cecile
approved these changes
Mar 11, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Lovely! No complaints here: that's pretty much exactly how I would have implemented this. You even spotted the a11y integration.
alice-i-cecile
added
X-Uncontroversial
viridia
approved these changes
Mar 11, 2026
Contributor
Author
|
Thank you! |
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Sliderwidget auto-detects orientation based on dimensions (vertical if height > width). This causes the Feathers slider to behave as vertical when its layout happens to be taller than wide, while its visuals (gradient direction, cursor icon) are hardcoded as horizontal.Adds a
SliderOrientationenum (Auto/Horizontal/Vertical) to give explicit control. Sets the Feathers sliders toHorizontalso their interaction matches their presentation.Fixes #23294