Derive Reflect for ParsedPath and its children#23371
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Mar 15, 2026
Merged
Derive Reflect for ParsedPath and its children#23371alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
alice-i-cecile
added
D-Trivial
alice-i-cecile
approved these changes
Mar 15, 2026
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
# Objective Fixes bevyengine#22974 ## Solution This uses the standard Reflect derive macro to ParsedPath and the types it uses. It doesn't do anything special to handle the `'a` parameter in `Access<'a>`, but that's fine because `ParsedPath` uses `'static` for that parameter anyway. ## Testing I built the docs locally to make sure the implementations were being derived. <img width="1020" height="253" alt="image" src="https://github.com/user-attachments/assets/d3fb5630-52f5-4bad-9873-2596684b36a2" /> I also verified that the derive macro created the Enum instance for Access that we'd expect. <img width="1010" height="86" alt="image" src="https://github.com/user-attachments/assets/ef4d52f3-2dad-4442-b56e-2d3d4bc32f52" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #22974
Solution
This uses the standard Reflect derive macro to ParsedPath and the types it uses. It doesn't do anything special to handle the
'aparameter inAccess<'a>, but that's fine becauseParsedPathuses'staticfor that parameter anyway.Testing
I built the docs locally to make sure the implementations were being derived.
I also verified that the derive macro created the Enum instance for Access that we'd expect.