Refactor section_buffer from tuple to named struct#23398
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Mar 18, 2026
Merged
Refactor section_buffer from tuple to named struct#23398alice-i-cecile merged 3 commits intobevyengine:mainfrom
section_buffer from tuple to named struct#23398alice-i-cecile merged 3 commits intobevyengine:mainfrom
Conversation
kfc35
added
S-Blocked
alice-i-cecile
added
X-Uncontroversial
kfc35
added
the
S-Waiting-on-Author
Contributor
|
Now that #23380 has been merged, I think this needs a merge from main @gregcsokas |
kfc35
reviewed
Mar 18, 2026
kfc35
removed
the
S-Blocked
…ability and maintainability # Conflicts: # crates/bevy_text/src/pipeline.rs
gregcsokas
force-pushed
the
refactor-section_buffer
branch
from
02a611c to
d3b7d0a
Compare
Contributor
Author
|
Hey @kfc35 I fixed the mess |
kfc35
added
S-Needs-Review
kfc35
approved these changes
Mar 18, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
Approving with the assumption that the duplicate lines are removed
| } | ||
|
|
||
| self.text_buffer.clear(); | ||
| for (_, span, _, _, _, _) in §ions { |
alice-i-cecile
approved these changes
Mar 18, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
Fixes bevyengine#23396 Please merge it after bevyengine#23380
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23396
Please merge it after #23380