Skip to content

Fix spot and point light retained view entity#23402

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/shadow-fix
Mar 18, 2026
Merged

Fix spot and point light retained view entity#23402
alice-i-cecile merged 1 commit intobevyengine:mainfrom
atlv24:ad/shadow-fix

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Mar 17, 2026

Objective

  • If you have two cameras rendering a scene with shadows, and you despawn one of the cameras, the shadows on the other stop working

Solution

  • The retained view entity should not include camera, because the shadows are camera agnostic (unlike directional)

Testing

  • verified fix on a tao integration im working on which revealed this originally

@atlv24 atlv24 added this to the 0.19 milestone Mar 17, 2026
@atlv24 atlv24 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 17, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Mar 17, 2026
@atlv24 atlv24 requested review from pcwalton and tychedelia March 17, 2026 23:05
pcwalton
pcwalton approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@pcwalton pcwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@atlv24 atlv24 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 18, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 18, 2026
Merged via the queue into bevyengine:main with commit 8f45da5 Mar 18, 2026
47 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Mar 18, 2026
splo pushed a commit to splo/bevy that referenced this pull request Mar 31, 2026
@atlv24 @splo
Fix spot and point light retained view entity (bevyengine#23402)
eed11df 
# Objective

- If you have two cameras rendering a scene with shadows, and you
despawn one of the cameras, the shadows on the other stop working

## Solution

- The retained view entity should not include camera, because the
shadows are camera agnostic (unlike directional)

## Testing

- verified fix on a tao integration im working on which revealed this
originally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tychedelia tychedelia Awaiting requested review from tychedelia

2 more reviewers

@pcwalton pcwalton pcwalton approved these changes

@JMS55 JMS55 JMS55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

4 participants

@atlv24 @pcwalton @JMS55 @alice-i-cecile