Merged
Conversation
…o a single component named `TextSection`.
ickshonpe
added
A-Text
alice-i-cecile
approved these changes
Mar 20, 2026
Zeophlite
reviewed
Mar 21, 2026
ickshonpe
added
S-Ready-For-Final-Review
Zeophlite
approved these changes
Mar 21, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
# Objective There are three separate traits for primary text components: `TextRoot`, `TextSpanAccess` and `TextSpanComponent`. They all provide the same functionality and can be consolidated into a single trait. The method names on `TextSpanAccess`'s (`read_span` and `write_span`) aren't ideal either. The names imply performing an action, not just the return of a reference, and should be changed to something more idiomatic. ## Solution * Renamed `TextSpanAccess` to `TextSection` and added a `From<String>` trait bound. * Renamed `read_span` to `get_text`. * Renamed `write_span` to `get_text_mut`. * Removed the `TextRoot` and `TextSpanComponent`. * Replaced all usages of `TextRoot` and `TextSpanComponent` with `TextSection`. * Renamed the private `TextSection` struct in the `pipeline` module to `TextSectionView`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
There are three separate traits for primary text components:
TextRoot,TextSpanAccessandTextSpanComponent.They all provide the same functionality and can be consolidated into a single trait.
The method names on
TextSpanAccess's (read_spanandwrite_span) aren't ideal either. The names imply performing an action, not just the return of a reference, and should be changed to something more idiomatic.Solution
TextSpanAccesstoTextSectionand added aFrom<String>trait bound.read_spantoget_text.write_spantoget_text_mut.TextRootandTextSpanComponent.TextRootandTextSpanComponentwithTextSection.TextSectionstruct in thepipelinemodule toTextSectionView.