Skip to content

Move extra_buffer_usages to MeshAllocatorSettings#23444

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
atlv24:ad/mesh-allocator-fix
Mar 21, 2026
Merged

Move extra_buffer_usages to MeshAllocatorSettings#23444
alice-i-cecile merged 2 commits intobevyengine:mainfrom
atlv24:ad/mesh-allocator-fix

Conversation

@atlv24
Copy link
Contributor

@atlv24 atlv24 commented Mar 21, 2026

Objective

  • Fix startup crash on 3d_shapes example and anything that uses wireframes
  • Make sure extra_buffer_usages set arent lost on recovery

Solution

  • Move extra_buffer_usages to MeshAllocatorSettings

Testing

  • 3d_example doesnt crash

@atlv24 atlv24 added A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 21, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Mar 21, 2026
@atlv24 atlv24 added C-Bug An unexpected or incorrect behavior P-Crash A sudden unexpected crash labels Mar 21, 2026
@atlv24 atlv24 added this to the 0.19 milestone Mar 21, 2026
@atlv24 atlv24 requested review from pcwalton and tychedelia March 21, 2026 06:11
@atlv24 atlv24 added the D-Straightforward Simple bug fixes and API improvements, docs, test and examples label Mar 21, 2026
@atlv24 atlv24 force-pushed the ad/mesh-allocator-fix branch from 49a8057 to 58a7aa3 Compare March 21, 2026 06:38
@atlv24 atlv24 added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Mar 21, 2026
pcwalton
pcwalton approved these changes Mar 21, 2026
View reviewed changes
Copy link
Contributor

@pcwalton pcwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 21, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 21, 2026
Merged via the queue into bevyengine:main with commit 888ab36 Mar 21, 2026
42 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Mar 21, 2026
@pcwalton pcwalton mentioned this pull request Mar 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tychedelia tychedelia Awaiting requested review from tychedelia

+1 more reviewer

@pcwalton pcwalton pcwalton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide P-Crash A sudden unexpected crash P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

3 participants

@atlv24 @pcwalton @alice-i-cecile