Closed
Conversation
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
S-Needs-Benchmarking
| &GlobalTransform, | ||
| Has<NoFrustumCulling>, | ||
| Has<VisibilityRange>, | ||
| Has<NoCpuCulling>, |
Member
There was a problem hiding this comment.
This is likely to regress performance badly in large scenes, since we're now doing an O(n) scan over all renderable entities, even if they have NoCpuCulling.
alice-i-cecile
added
the
X-Contentious
Contributor
|
I think #23534 is the correct fix for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #23473
Solution
Modified check_visibility_cpu_culling to query for Has<NoCpuCulling>.
Testing
Did you test these changes? If so, how?
I tested with these examples, with and without NoCpuCulling (where aplicable):
I also tested with the code provided in Adding NoCpuCulling to a mesh at runtime hides the mesh #23473
Are there any parts that need more testing?
Not that I reckon
How can other people (reviewers) test your changes? Is there anything specific they need to know?
Run the tests above
If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
I tested on a Macbook M3 pro with Tahoe 26.4 beta.