Add and remove accessibility toggled properly for Checkable#23532
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Mar 27, 2026
Merged
Add and remove accessibility toggled properly for Checkable#23532alice-i-cecile merged 1 commit intobevyengine:mainfrom
alice-i-cecile merged 1 commit intobevyengine:mainfrom
Conversation
GiantBlargg
changed the title
alice-i-cecile
added
C-Bug
alice-i-cecile
added
A-Accessibility
alice-i-cecile
approved these changes
Mar 27, 2026
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
…ne#23532) # Objective This didn't look right to me, based on the names these functions are listening to the wrong events. Like someone copy-pasted the function signature but didn't correct it. Introduced in bevyengine#19665 ## Solution Listen for the correct events ## Testing I did not test this at all! This issue does not affect me. I wasn't sure how to get someone with more familiarity here to take a look.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This didn't look right to me, based on the names these functions are listening to the wrong events. Like someone copy-pasted the function signature but didn't correct it.
Introduced in #19665
Solution
Listen for the correct events
Testing
I did not test this at all! This issue does not affect me.
I wasn't sure how to get someone with more familiarity here to take a look.