enable tracing for rodio#23557
Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom Mar 29, 2026
Merged
Conversation
alice-i-cecile
approved these changes
Mar 29, 2026
alice-i-cecile
added
D-Trivial
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
# Objective - All Bevy programs with bevy_audio print a line to stderr when they exit: ``` Dropping DeviceSink, audio playing through this sink will stop, to prevent this message from appearing use tracing or call `.log_on_drop(false)` on this DeviceSink ``` - This is an expected print by rodio: https://github.com/RustAudio/rodio/blob/7e9ba6dd017abb88a1de8c287849c89c3624437d/src/stream.rs#L99-L108 ## Solution - Enable the tracing feature so that it's logged instead of printed - set `log_on_drop(false)` on the audio sink created by Bevy. It's expected to stop playing sound when it's dropped
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
https://github.com/RustAudio/rodio/blob/7e9ba6dd017abb88a1de8c287849c89c3624437d/src/stream.rs#L99-L108
Solution
log_on_drop(false)on the audio sink created by Bevy. It's expected to stop playing sound when it's dropped