Skip to content

Make failed image loads result in a failed Gltf load.#23562

Open
andriyDev wants to merge 2 commits intobevyengine:mainfrom
andriyDev:fix-23465
Open

Make failed image loads result in a failed Gltf load.#23562
andriyDev wants to merge 2 commits intobevyengine:mainfrom
andriyDev:fix-23465

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

@andriyDev andriyDev commented Mar 28, 2026

Objective

Solution

  • Just propagate the GltfError instead of just logging it and moving on.

Testing

  • Added a test.

@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-glTF Related to the glTF 3D scene/model format labels Mar 28, 2026
@andriyDev andriyDev added this to the 0.19 milestone Mar 28, 2026
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ChristopherBiscardi ChristopherBiscardi ChristopherBiscardi approved these changes

@JMS55 JMS55 JMS55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-glTF Related to the glTF 3D scene/model format C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

glTF texture handles shift when image loading fails, assigning wrong textures to materials

3 participants

@andriyDev @ChristopherBiscardi @JMS55