Hashmap visit asset dependencies impl#23566
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Mar 29, 2026
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Mar 29, 2026
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Mar 31, 2026
# Objective
- Allow tagging of HashMaps with `#[dependency]`, for assets which
contain variable binding assignments to asset handles.
## Solution
- The solution is to create an implementation of VisitAssetDependencies
for HashMap that behaves similarly to HashSet.
## Testing
- The changes were tested by adding `map_handles` and
`untyped_map_handles` to `StructTestAsset` and `EnumTestAsset`. Then,
`cargo test` was ran in `crates/bevy_asset`.
## Showcase
I plan to use this to create a map of material bindings to material
handles. In the below example, `materials` is a map of bindings (e.g.
"$east", "$south"). Each `Element` contains up to six references, so
this helps when there are block templates that only use one material for
all faces.
```rust
#[derive(Asset, Reflect, Clone)]
#[type_path = "ovx::blocks::template"]
#[type_name = "BlockTemplate"]
pub struct BlockTemplate {
#[dependency]
pub inherits: Vec<Handle<BlockTemplate>>,
#[dependency]
pub materials: HashMap<String, Handle<BlockMaterial>>,
pub elements: HashMap<String, Element>,
pub variants: HashMap<String, Variant>,
pub states: HashMap<String, BlockState>,
}
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#[dependency], for assets which contain variable binding assignments to asset handles.Solution
Testing
map_handlesanduntyped_map_handlestoStructTestAssetandEnumTestAsset. Then,cargo testwas ran incrates/bevy_asset.Showcase
I plan to use this to create a map of material bindings to material handles. In the below example,
materialsis a map of bindings (e.g. "$east", "$south"). EachElementcontains up to six references, so this helps when there are block templates that only use one material for all faces.