Skip to content

Reposition Popovers in PostLayout using UiGlobalTransform.#23587

Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom
ickshonpe:transform-popovers
Mar 30, 2026
Merged

Reposition Popovers in PostLayout using UiGlobalTransform.#23587
alice-i-cecile merged 7 commits intobevyengine:mainfrom
ickshonpe:transform-popovers

Conversation

@ickshonpe
Copy link
Copy Markdown
Contributor

@ickshonpe ickshonpe commented Mar 30, 2026

Objective

Reposition Popovers in PostLayout using UiGlobalTransform.

Related: #23346

Solution

  • Move popover_system into the PostLayout system set.
  • Reposition Popovers in PostLayout using UiGlobalTransform.
  • Updates are immediate, so removed the trick with visibility.

Testing

cargo run --example standard_widgets

The pop up menu still seems to work anyway.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 30, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in UI Mar 30, 2026
Copy link
Copy Markdown
Contributor

@rossleonardy rossleonardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it behaves the same for me as main.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 30, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 30, 2026
Merged via the queue into bevyengine:main with commit 84be6ac Mar 30, 2026
38 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in UI Mar 30, 2026
splo pushed a commit to splo/bevy that referenced this pull request Mar 31, 2026
…yengine#23587)

# Objective

Reposition `Popovers` in `PostLayout` using `UiGlobalTransform`.
 
Related: bevyengine#23346

## Solution

* Move `popover_system` into the `PostLayout` system set.
* Reposition `Popovers` in `PostLayout` using `UiGlobalTransform`.
* Updates are immediate, so removed the trick with visibility.

## Testing

```
cargo run --example standard_widgets
```

The pop up menu still seems to work anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants