Skip to content

Atmosphere as entity migration guide#23675

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
mate-h:m/atmosphere-entity-migation-guide
Apr 7, 2026
Merged

Atmosphere as entity migration guide#23675
alice-i-cecile merged 3 commits intobevyengine:mainfrom
mate-h:m/atmosphere-entity-migation-guide

Conversation

@mate-h
Copy link
Copy Markdown
Contributor

@mate-h mate-h commented Apr 5, 2026

Objective

Solution

  • Write a migration guide detailing the breaking changes
  • Adhere to a friendly non-technical tone
  • Explain the new way of scaling the atmosphere with Transform

Out of scope

  • Explain how to customize the apparent up axis (i.e. horizon's orientation) -> this should follow intuitively but maybe I should add this too? or maybe this belongs in a release note instead?

@mate-h mate-h added C-Docs An addition or correction to our documentation M-Release-Note Work that should be called out in the blog due to impact labels Apr 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@mate-h mate-h requested a review from ecoskey April 5, 2026 18:41
@mate-h mate-h added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Apr 5, 2026
Copy link
Copy Markdown
Contributor

@ecoskey ecoskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a sentence somewhere that makes it clear AtmosphereSettings is the component that enables the effect now? Most will probably be able to figure it out from context but it's also the kind of thing that's easily missed. Otherwise, looks good!

@kfc35 kfc35 added M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide and removed M-Release-Note Work that should be called out in the blog due to impact labels Apr 6, 2026
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 6, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 6, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 6, 2026
Merged via the queue into bevyengine:main with commit 437d982 Apr 7, 2026
44 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants