Skip to content

Remove SystemState from more benches#23705

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
wduminy:less_system_state
Apr 12, 2026
Merged

Remove SystemState from more benches#23705
alice-i-cecile merged 2 commits intobevyengine:mainfrom
wduminy:less_system_state

Conversation

@wduminy
Copy link
Copy Markdown
Contributor

@wduminy wduminy commented Apr 7, 2026 •
edited
Loading

Objective

Fixes #23238
I thought there would be more instances to fix :-)

Solution

Same as #23687

Testing

Ran affected benches and the regression results are a bit flaky -- but seeing that only the regression bench logic has been changed, this should be OK.

cargo bench -p benches --bench ecs -- iter_fragmented

@wduminy wduminy marked this pull request as ready for review April 7, 2026 18:44
@kfc35 kfc35 added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change C-Benchmarks Stress tests and benchmarks used to measure how fast things are X-Uncontroversial This work is generally agreed upon labels Apr 8, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in ECS Apr 8, 2026
@kfc35 kfc35 added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Apr 8, 2026
@chescock chescock added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 8, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 12, 2026
Merged via the queue into bevyengine:main with commit 9c5508c Apr 12, 2026
50 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in ECS Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@kfc35 kfc35 kfc35 approved these changes

@chescock chescock chescock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ECS Entities, components, systems, and events C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

ECS
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unnecessary usage of SystemState API in tests and benchmarks

4 participants

@wduminy @kfc35 @alice-i-cecile @chescock