Don't clobber default filters if env filters exist#23762
Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom Apr 12, 2026
Merged
Don't clobber default filters if env filters exist#23762alice-i-cecile merged 2 commits intobevyengine:mainfrom
alice-i-cecile merged 2 commits intobevyengine:mainfrom
Conversation
loreball
approved these changes
Apr 12, 2026
alice-i-cecile
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
LogPluginhas some default filters which suppress unhelpful noisy logging from dependencies. However, if theRUST_LOGenv var is set, it completely discards these default filters in favour of whatever the user set, thus unleashing all of the spammy logging that is usually hidden.Solution
Refactor the filter setup so that
RUST_LOGfilter configuration is applied on-top of the default filters, instead of entirely replacing them. TheEnvFilteris constructed with the default filters, then any filters fromRUST_LOGare parsed and added afterwards, so that they can selectively override the default filters, should the user desire that.Testing
Manually tested with the
logsexample and variousRUST_LOGvalues.