fix(RenderDebugOverlayPlugin): Require the bevy_pbr feature for inclusion in DefaultPlugins#23766
Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom Apr 12, 2026
Conversation
alice-i-cecile
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_dev_toolscauses crash #23673RenderDebugOverlayPluginis aDefaultPluginthat currently only requires thebevy_dev_toolsfeature. However, under the hood in itsinit_render_debug_overlay_pipelinesystem, it requires theMeshPipelineViewLayoutsresource to be initialized. The resource is initialized in theMeshRenderPlugin(systeminit_mesh_pipeline_view_layouts). TheMeshRenderPluginis part of thePbrPlugin, which is a plugin inDefaultPluginsthat requires thebevy_pbrfeature. This causes an error when you have a bevy project withDefaultPlugins, without default features, and have thebevy_dev_toolsfeature enabled.Solution
RenderDebugOverlayPluginadditionally requires thebevy_pbrfeature so that it can be included inDefaultPlugins. This ensuresMeshPipelineViewLayoutsis initialized so thatRenderDebugOverlayPlugincan properly initialize.RenderDebugOverlayPlugincan be more dexterously changed to still be enabled with just thebevy_dev_toolsfeature, andbevy_pbrspecific logic can be handled within the plugin itself, then this can PR can be rejected.Testing