Skip to content

fix(RenderDebugOverlayPlugin): Require the bevy_pbr feature for inclusion in DefaultPlugins#23766

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kfc35:23673_render_debug_overlay_needs_pbr
Apr 12, 2026
Merged

fix(RenderDebugOverlayPlugin): Require the bevy_pbr feature for inclusion in DefaultPlugins#23766
alice-i-cecile merged 1 commit intobevyengine:mainfrom
kfc35:23673_render_debug_overlay_needs_pbr

Conversation

@kfc35
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 commented Apr 12, 2026

Objective

  • Fixes bevy_dev_tools causes crash #23673
  • The RenderDebugOverlayPlugin is a DefaultPlugin that currently only requires the bevy_dev_tools feature. However, under the hood in its init_render_debug_overlay_pipeline system, it requires the MeshPipelineViewLayouts resource to be initialized. The resource is initialized in the MeshRenderPlugin (system init_mesh_pipeline_view_layouts). The MeshRenderPlugin is part of the PbrPlugin, which is a plugin in DefaultPlugins that requires the bevy_pbr feature. This causes an error when you have a bevy project with DefaultPlugins, without default features, and have the bevy_dev_tools feature enabled.

Solution

  • The RenderDebugOverlayPlugin additionally requires the bevy_pbr feature so that it can be included in DefaultPlugins. This ensures MeshPipelineViewLayouts is initialized so that RenderDebugOverlayPlugin can properly initialize.
  • If RenderDebugOverlayPlugin can be more dexterously changed to still be enabled with just the bevy_dev_tools feature, and bevy_pbr specific logic can be handled within the plugin itself, then this can PR can be rejected.

Testing

  • I created a scratch bevy project with the configuration described in the linked issue, but pointing to this branch fix for its bevy dependency. It successfully runs.

@kfc35 kfc35 added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash A-Dev-Tools Tools used to debug Bevy applications. S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 12, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 12, 2026
@kfc35 kfc35 added the C-Bug An unexpected or incorrect behavior label Apr 12, 2026
@alice-i-cecile alice-i-cecile added the D-Trivial Nice and easy! A great choice to get started with Bevy label Apr 12, 2026
@bevyengine bevyengine deleted a comment from github-actions bot Apr 12, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 12, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 12, 2026
Merged via the queue into bevyengine:main with commit eada2bf Apr 12, 2026
53 checks passed
@github-project-automation github-project-automation bot moved this from Needs SME Triage to Done in Rendering Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Dev-Tools Tools used to debug Bevy applications. A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Crash A sudden unexpected crash S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

bevy_dev_tools causes crash

2 participants