Skip to content

Allow configuring fullscreen material system order#23786

Open
beicause wants to merge 2 commits intobevyengine:mainfrom
beicause:fullscreen-material-order
Open

Allow configuring fullscreen material system order#23786
beicause wants to merge 2 commits intobevyengine:mainfrom
beicause:fullscreen-material-order

Conversation

@beicause
Copy link
Copy Markdown
Contributor

Objective

Fixes #23781

When Hdr is on, the order of tonemapping and fullscreen_material_system is uncertain and the result of main pass can be cleared. run_in run_before run_after can only specify system set and can't specify a specific system and them hardcode Core3dSystems.

Solution

Replace run_in run_before run_after with fn schedule_configs(system: ScheduleConfigs<BoxedSystem>) -> ScheduleConfigs<BoxedSystem>

Testing

Run fullscreen_material example with Hdr

Copy link
Copy Markdown
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know this ScheduleConfigs api existed, that's a much nicer solution.

Can you update the comment in the example that shows how to set the config for 2d?

@IceSentry IceSentry added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 13, 2026
@github-project-automation github-project-automation bot moved this to Needs SME Triage in Rendering Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review Needs reviewer attention (from anyone!) to move forward

Projects

Status: Needs SME Triage

Development

Successfully merging this pull request may close these issues.

fullscreen_material example doesn't render properly with Hdr on

2 participants