Skip to content

Use EntityHashMap and EntityHashSet when possible#23810

Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom
beicause:use-entity-hasher
Apr 15, 2026
Merged

Use EntityHashMap and EntityHashSet when possible#23810
alice-i-cecile merged 4 commits intobevyengine:mainfrom
beicause:use-entity-hasher

Conversation

@beicause
Copy link
Copy Markdown
Member

@beicause beicause commented Apr 15, 2026

Objective

Replace HashMap<Entity, T> and HashSet<Entity> with EntityHashMap and EntityHashSet for better performance.

Solution

Replace them.

Testing

CI

@beicause beicause force-pushed the use-entity-hasher branch from 4539d8c to b1ccdf4 Compare April 15, 2026 04:47
@alice-i-cecile alice-i-cecile added C-Performance A change motivated by improving speed, memory usage or compile times C-Code-Quality A section of code that is hard to understand or change A-Cross-Cutting Impacts the entire engine D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 15, 2026
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 15, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 15, 2026
Merged via the queue into bevyengine:main with commit 1fa8f03 Apr 15, 2026
50 checks passed
@beicause beicause deleted the use-entity-hasher branch April 15, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@urben1680 urben1680 urben1680 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Cross-Cutting Impacts the entire engine C-Code-Quality A section of code that is hard to understand or change C-Performance A change motivated by improving speed, memory usage or compile times D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beicause @alice-i-cecile @urben1680