Skip to content

Disclosure toggle widget.#23817

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
viridia:disclosure
Apr 16, 2026
Merged

Disclosure toggle widget.#23817
alice-i-cecile merged 3 commits intobevyengine:mainfrom
viridia:disclosure

Conversation

@viridia
Copy link
Copy Markdown
Contributor

@viridia viridia commented Apr 15, 2026

Objective

Part of #19236

The "disclosure toggle" is a small checkbox-like widget which displays a chevron that toggles between pointing right and pointing down.

Testing

Manual testing

@alice-i-cecile alice-i-cecile added C-Feature A new feature, making something new possible D-Trivial Nice and easy! A great choice to get started with Bevy A-UI Graphical user interfaces, styles, layouts, and widgets S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 16, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Apr 16, 2026
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples A-Editor Graphical tools to make Bevy games X-Uncontroversial This work is generally agreed upon and removed D-Trivial Nice and easy! A great choice to get started with Bevy labels Apr 16, 2026
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in the gallery

});
}

fn set_toggle_colors(
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m assuming the unused variables are there to be used in the future (theme & slide token)? looked at the similar code for slide_token in toggle_switch and not sure if it’s totally applicable here given that there’s no ThemeBackgroundColor

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! OK, so this was a very old branch that I resurrected, and I guess I overlooked this. Let me fix it.

@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 16, 2026
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving again to let you know I approve your updates. Tested an InteractionDisabled disclosure toggle to make sure

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 16, 2026
Merged via the queue into bevyengine:main with commit 6b4a003 Apr 16, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Apr 16, 2026
@viridia viridia deleted the disclosure branch April 16, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Editor Graphical tools to make Bevy games A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants