Skip to content

Fix QueuedScenes not existing when spawning queued scenes#23821

Merged
alice-i-cecile merged 2 commits intobevyengine:mainfrom
cart:fix_queued_scenes
Apr 17, 2026
Merged

Fix QueuedScenes not existing when spawning queued scenes#23821
alice-i-cecile merged 2 commits intobevyengine:mainfrom
cart:fix_queued_scenes

Conversation

@cart
Copy link
Copy Markdown
Member

@cart cart commented Apr 16, 2026 •
edited
Loading

Objective

Fix #23731

Solution

  1. Slim down QueuedScenes to the minimum by breaking out "waiting scenes" into its own resource
  2. Store two copies of QueuedScene (one in the system and one in the resource) and mem::swap them when the system runs

Testing

Added a test, derived from the repro in #23731

@cart cart added C-Bug An unexpected or incorrect behavior A-Scenes Composing and serializing ECS objects labels Apr 16, 2026
@cart cart added this to the 0.19 milestone Apr 16, 2026
@alice-i-cecile alice-i-cecile requested a review from viridia April 16, 2026 02:39
@alice-i-cecile alice-i-cecile added D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 16, 2026
@cart cart force-pushed the fix_queued_scenes branch from 67e1e7b to bfd224f Compare April 16, 2026 02:43
@alice-i-cecile alice-i-cecile requested a review from kfc35 April 17, 2026 00:23
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 17, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 17, 2026
Merged via the queue into bevyengine:main with commit 9c27c26 Apr 17, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@viridia viridia Awaiting requested review from viridia

+1 more reviewer

@kfc35 kfc35 kfc35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Scenes Composing and serializing ECS objects C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

Panic when attempting to spawn scene from component spawned by scene

3 participants

@cart @kfc35 @alice-i-cecile