feathers_gallery infinite update loop fix#23827
Merged
alice-i-cecile merged 4 commits intobevyengine:mainfrom Apr 17, 2026
Merged
feathers_gallery infinite update loop fix#23827alice-i-cecile merged 4 commits intobevyengine:mainfrom
feathers_gallery infinite update loop fix#23827alice-i-cecile merged 4 commits intobevyengine:mainfrom
Conversation
On a `TextEditChange` `handle_hex_color_change` updates `DemoWidgetStates` which causes `update_colors` to update the hex input triggering another `TextEditChange`. This commit fixes the problem by only updating `DemoWidgetStates` if the color value is different.
ickshonpe
changed the title
feathers_gallery example infinite update loop fixfeathers_gallery infinite update loop fix
ickshonpe
added
C-Examples
ickshonpe
added
D-Trivial
Zeophlite
approved these changes
Apr 16, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
…/github.com/ickshonpe/bevy into feathers-gallery-color-change-detection-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In the
feathers_galleryexample, on aTextEditChangehandle_hex_color_changeupdatesDemoWidgetStateswhich causesupdate_colorsto update the hex input triggering anotherTextEditChange.Solution
Only update
DemoWidgetStatesinhandle_hex_color_changeif the new color is different.