Skip to content

Fix CI errors for Rust 1.95#23829

Merged
alice-i-cecile merged 8 commits intobevyengine:mainfrom
alice-i-cecile:rustc-broke-ci
Apr 16, 2026
Merged

Fix CI errors for Rust 1.95#23829
alice-i-cecile merged 8 commits intobevyengine:mainfrom
alice-i-cecile:rustc-broke-ci

Conversation

@alice-i-cecile
Copy link
Copy Markdown
Member

Objective

CI is broken

Solution

Look at the CI errors. Fix them.

Testing

Let's see if CI is green!

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy P-Critical This must be fixed immediately or contributors or users will be severely impacted X-Uncontroversial This work is generally agreed upon S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Cross-Cutting Impacts the entire engine labels Apr 16, 2026
Copy link
Copy Markdown
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, agree with expecting the explicit_counter_loop, that seems like one that will raise a lot annoying false positives.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 16, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 16, 2026
Merged via the queue into bevyengine:main with commit 85212f7 Apr 16, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Cross-Cutting Impacts the entire engine D-Trivial Nice and easy! A great choice to get started with Bevy P-Critical This must be fixed immediately or contributors or users will be severely impacted S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants