Fix and Polish Feathers Toggle Switch#23830
Merged
alice-i-cecile merged 12 commits intobevyengine:mainfrom Apr 17, 2026
Merged
Conversation
Contributor
Author
|
I added quite a few style tokens this time around. Please let me know if any doc comments don't match the token variable name or token string name. |
alice-i-cecile
added
C-Bug
alice-i-cecile
added
D-Modest
| /// Switch background around the switch (disabled) | ||
| pub const SWITCH_BG_DISABLED: ThemeToken = ThemeToken::new_static("feathers.switch.bg.disabled"); | ||
| /// Switch background around the checkmark | ||
| /// Switch background around the switch (checked) |
alice-i-cecile
approved these changes
Apr 16, 2026
Member
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good! Surprisingly straightforward. I like the new styles too.
alice-i-cecile
added
D-Straightforward
viridia
reviewed
Apr 16, 2026
viridia
approved these changes
Apr 16, 2026
Atlas16A
approved these changes
Apr 16, 2026
kfc35
added
S-Ready-For-Final-Review
auto-merge was automatically disabled
April 17, 2026 01:59
Head branch was pushed to by a user without write access
This was referenced Apr 18, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
# Objective Continuation of #23820 and #23830 This fixes the clicking behavior to toggle on mouse-release, or on mouse-press with the `ActivateOnPress` component. More styling tokens are also added for transition states. --- ## Showcase ### Before <img width="91" height="91" alt="Screenshot 2026-04-17 at 11 32 39 PM" src="https://github.com/user-attachments/assets/b1b8832d-7aaa-45ee-a641-4c100d44a232" /> ### After <img width="91" height="91" alt="Screenshot 2026-04-17 at 11 13 33 PM" src="https://github.com/user-attachments/assets/d3cf5bf6-1dfe-4d88-8dd1-fc719449e7b5" /> (Not pictured: new intermediate styling for mouse press) --------- Co-authored-by: François Mockers <francois.mockers@vleue.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 19, 2026
# Objective Continuation of #23820, #23830, #23869 This adds style tokens to the slider, and adds Pressed events to do so. ## Showcase No visual change aside from adding hover and pressed style tokens. <img width="373" height="35" alt="Screenshot 2026-04-18 at 8 05 17 PM" src="https://github.com/user-attachments/assets/d9fb38f2-10d9-437d-b776-e6d74fdc3756" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This is a continuation of #23820 for toggle switches to fix their clicking behavior and add more style tokens. Again, adding the
ActivateOnPresscomponent will change its state instantly on mouse-press rather than mouse-release.Styling is also changed for visibility and disambiguation.
Showcase
Before
After
(Not pictured: new intermediate styling for mouse press)