fix assign_to double drop when drop panics#23833
Open
nitzan-treg wants to merge 1 commit intobevyengine:mainfrom
Open
fix assign_to double drop when drop panics#23833nitzan-treg wants to merge 1 commit intobevyengine:mainfrom
nitzan-treg wants to merge 1 commit intobevyengine:mainfrom
Conversation
`replaced the manual drop_in_place + write_to in assign_to with a simple *dst = self.read(). the old code would drop dst first and if that panicked you'd end up with a freed pointer still accessible, which is ub. using rust's assignment operator keeps things safe since the drop and write are handled together properly` Signed-off-by: nitzan-treg <nitzan.tregerman@gmail.com>
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
Member
|
@KyleDavidE, I'd appreciate your review here as the person who spotted this :) |
alice-i-cecile
added
P-Unsound
|
I as mentioned in the issue I will flag that in the case that |
Member
|
My current preference remains to simply delete this code completely. We should not be keeping around unused unsafe code in a crate that has very few external users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey, saw #23500 and took a look
replaced the manual drop_in_place + write_to in assign_to with a simple *dst = self.read(). the old code would drop dst first and if that panicked you'd end up with a freed pointer still accessible, which is UB. using rust's assignment operator keeps things safe since the drop and write are handled together properly
fixes #23500