Add ReadbackOnce component to help one-shot readbacks.#23845
Open
tychedelia wants to merge 6 commits into
Open
Add ReadbackOnce component to help one-shot readbacks.#23845tychedelia wants to merge 6 commits into
tychedelia wants to merge 6 commits into
Conversation
tychedelia
added
A-Rendering
IceSentry
reviewed
Apr 17, 2026
| } | ||
|
|
||
| fn cleanup_readback_once( | ||
| event: On<ReadbackComplete>, |
Contributor
There was a problem hiding this comment.
Will that work correctly if the readback happens a few frames later? Wouldn't that trigger multiple readback operations until this is cleared?
Member
Author
There was a problem hiding this comment.
Yes, this should be a system that runs in first.
Contributor
There was a problem hiding this comment.
Yeah, that was my thought too. I guess it might break if someone spawns it in First and doesn't order it but that can be handled with good docs. That or tracking the frame it was added and making sure it's the next one before deleting but I think doing it in First unconditionally is good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users are sometimes confused about the fact that the
Readbackcomponent will fire multiple observers (once per every frame it exists in the main world). This newReadbackOncecomponent helps a bit with the ux of spawning a readback that only fires once.