Fix UI accessibility transforms and update ordering#23859
Merged
alice-i-cecile merged 5 commits intobevyengine:mainfrom Apr 18, 2026
Merged
Fix UI accessibility transforms and update ordering#23859alice-i-cecile merged 5 commits intobevyengine:mainfrom
alice-i-cecile merged 5 commits intobevyengine:mainfrom
Conversation
…that updates the accesskit transforms for UI `AccessibilityNode`'s as well their rects.
Contributor
|
Could you try locally adding #23846 and see if this creates any new ambiguities (any involving this new system)? |
Contributor
|
Actually I ended up doing this myself, and yeah looks like this does indeed resolve the ambiguities! |
alice-i-cecile
approved these changes
Apr 17, 2026
andriyDev
approved these changes
Apr 17, 2026
Member
This was not done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_winitupdates the accesskit adaptors, otherwise there will be a frames delay.Solution
Replaced the
calc_boundssystems with a new systemsync_bounds_and_transforms.Each accesskit
Nodecorresponding to anAccessibleNodeUI entity is now given object-centered coordinates for its bounding rect (instead of window coordinates) and a transform.Accesskit uses local transforms so if an accessible node also has an accessible parent, its transform has to be recomputed relative to its parent.
Testing
I modified the button example so that accesskit integration is enabled by default and the button is drawn at a 45 degrees angle.
Screen readers should only react when the pointer is directly over the rotated button if the changes are working.
The example changes should be reverted before merging.