ComputedStackIndex component#23878
Merged
alice-i-cecile merged 14 commits intobevyengine:mainfrom Apr 19, 2026
Merged
Conversation
…UiStackIndex component.
…/bevy into uistackindex-component
ickshonpe
added
A-Rendering
ickshonpe
added
C-Code-Quality
Contributor
Author
Just gonna check if it's no longer needed with the ambiguity detector. |
Contributor
Author
Even better, we can nuke all the ambiguity supression around |
andriyDev
approved these changes
Apr 18, 2026
Contributor
andriyDev
left a comment
andriyDev
left a comment
There was a problem hiding this comment.
Nice! I also verified this satisfies the strict ambiguities too (which I'm guessing you also ran yourself haha).
This comment was marked as resolved.
This comment was marked as resolved.
kfc35
approved these changes
Apr 19, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
lgtm for correctness, and happy to be rid of some ambiguities
kfc35
added
S-Ready-For-Final-Review
pull Bot
pushed a commit
to octoape/bevy
that referenced
this pull request
Apr 22, 2026
…evyengine#23939) # Objective Use `set_if_neq` to update the `ComputedStackIndex`s in `ui_stack_system` to enable change detection. (Missed in bevyengine#23878)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Split off the stack index field from
ComputedNodeinto its own specialized component.Fixes #23862
Solution
stack_indexfield and its accessor fromComputedNode.ComputedStackIndex, newtyping au32.ComputedStackIndexonComputedNode.ui_stack_system, query for and updateComputedStackIndexinstead ofComputedNode.ComputedStackIndex.ui_stack_system, as no longer needed.Notes
ui_stack_systemshould probably replace itsWith<Node>query filters withWith<ComputedStackIndex>. It uses the ghost hierarchy navigation params though, which complicates things, so I left them alone here.Noneindicating the UI node was removed from the layout viaDisplay::None.