"Run once" Scenes#23880
Merged
cart merged 9 commits intobevyengine:mainfrom Apr 20, 2026
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
alice-i-cecile
approved these changes
Apr 20, 2026
MalekiRe
approved these changes
Apr 20, 2026
Contributor
MalekiRe
left a comment
There was a problem hiding this comment.
The code LGTM on a functional level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
SceneandSceneListcurrently require "repeatability". This puts some burden on developers setting "field patches" in BSN, as the "right hand side" values must either be Copy or have a manual Clone. This results in scenes like:In practice, thanks to inheritance caching, repeatability is no longer required.
Solution
SceneandSceneListconsumeself.SceneBoxandSceneListBoxsubtraits to enableBox<dyn Scene>to implSceneand consume itself.FnOncefor patches.This enables the following code to work: