Skip to content

Handle the case where there is no resume time.#23885

Merged
mockersf merged 1 commit intobevyengine:mainfrom
andriyDev:fix-inf-wait
Apr 19, 2026
Merged

Handle the case where there is no resume time.#23885
mockersf merged 1 commit intobevyengine:mainfrom
andriyDev:fix-inf-wait

Conversation

@andriyDev
Copy link
Copy Markdown
Contributor

@andriyDev andriyDev commented Apr 19, 2026

Objective

  • Fix the case where the UpdateMode::reactive is set to Duration::MAX.

Solution

  • When StartCause::WaitCancelled::requested_resume is None, always report this case as not having elapsed the wait time.

Testing

  • Ran the desktop_request_redraw with UpdateMode::reactive(Duration::MAX) and now it updates only when a redraw happens or a window even happens!

@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Windowing Platform-agnostic interface layer to run your app in S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 19, 2026
@andriyDev andriyDev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 19, 2026
@mockersf mockersf added this pull request to the merge queue Apr 19, 2026
Merged via the queue into bevyengine:main with commit 15a6b5e Apr 19, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Windowing Platform-agnostic interface layer to run your app in C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants