Skip to content

Fix morph target motion blur#23894

Merged
alice-i-cecile merged 1 commit intobevyengine:mainfrom
greeble-dev:morph-target-motion-blur
Apr 21, 2026
Merged

Fix morph target motion blur#23894
alice-i-cecile merged 1 commit intobevyengine:mainfrom
greeble-dev:morph-target-motion-blur

Conversation

@greeble-dev
Copy link
Copy Markdown
Contributor

I didn't update a call to morph_prev_vertex in commit dbb003c (part of #23023), so the prepass shader fails to compile if motion blur is enabled.

Testing

cargo run --example many_morph_targets -- --count 4 --motion-blur
cargo run --example many_morph_targets -- --count 4

@greeble-dev greeble-dev requested a review from pcwalton April 20, 2026 10:58
@greeble-dev greeble-dev added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Regression Functionality that used to work but no longer does. Add a test for this! D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 20, 2026
@greeble-dev greeble-dev added this to the 0.19 milestone Apr 20, 2026
@greeble-dev
Copy link
Copy Markdown
Contributor Author

I'm adding this issue to the 0.19 milestone - hoping that's reasonable as it's a one-liner and fixes a regression that's new in 0.19.

@mnmaita mnmaita added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 21, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering Apr 21, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 21, 2026
Merged via the queue into bevyengine:main with commit 90a45fc Apr 21, 2026
51 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Straightforward Simple bug fixes and API improvements, docs, test and examples P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants